Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #71

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

alongosz
Copy link
Member

🎫 Issue IBX-8138

Description:

Applied rules from Symfony 5 Rector set lists.

For QA:

No QA needed. Regression tests should be enough.

Documentation:

This is code refactoring without behavior change. No documentation changes needed.

Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of times here types could be narrowed (string instead of string|array, for example) but as this process was automatic and this would require effort for little value, I'll be okay to not address that.

Applied rules:
 * AddReturnTypeDeclarationRector
Copy link

@adamwojs adamwojs merged commit 5e09f22 into main Aug 26, 2024
7 checks passed
@adamwojs adamwojs deleted the ibx-8138-symfony-5-rule-sets branch August 26, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants